Skip to content

Call UnnecessaryParenthesesVisitor on parent after RemoveObjectsIsNull #5900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2025
Merged

Call UnnecessaryParenthesesVisitor on parent after RemoveObjectsIsNull #5900

merged 2 commits into from
Aug 12, 2025

Conversation

timtebeek
Copy link
Member

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Aug 12, 2025
@timtebeek timtebeek mentioned this pull request Aug 12, 2025
Closed
@timtebeek timtebeek self-assigned this Aug 12, 2025
@timtebeek timtebeek added the bug Something isn't working label Aug 12, 2025
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Aug 12, 2025
github-actions[bot]
github-actions bot reviewed Aug 12, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-maven/src/main/java/org/openrewrite/maven/tree/Dependency.java
    • lines 26-26

@timtebeek timtebeek merged commit 3582c6e into main Aug 12, 2025
2 checks passed
@timtebeek timtebeek deleted the remove-unnecessary-parentheses-after-remove-objects-isNull branch August 12, 2025 11:41
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Aug 12, 2025
dcsekar pushed a commit to dcsekar/rewrite that referenced this pull request Aug 18, 2025
@timtebeek
Call UnnecessaryParenthesesVisitor on parent after `RemoveObjectsIs…
23cdf96 
…Null` (openrewrite#5900)

* Call `UnnecessaryParenthesesVisitor` on parent after `RemoveObjectsIsNull`

* Order imports on Maven Dependency.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@timtebeek timtebeek

Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RemoveObjectsIsNull doesn't remove unnecessary parentheses, if it
1 participant
@timtebeek