Stable label order for PrintMavenAsDot
#5893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (List<ResolvedDependency> deps : mrr.getDependencies().values()) { | ||
| for (ResolvedDependency dep : deps) { | ||
| // Build up index of all dependencies, so we can reference them by index in the DOT output | ||
| for (Scope scope : Scope.values()) { |
There was a problem hiding this comment.
Would it make sense to limit it to Compile, Runtime, Provided and Test like the loop lower down that is calling dotEdges(..) or would that not change things?
There was a problem hiding this comment.
Yes sure, makes sense. Also rendered the big disabled test SVG:
steve-aom-elliott
approved these changes
Aug 11, 2025
Merged
MBoegers
pushed a commit
that referenced
this pull request
Aug 12, 2025
* Stable label order for `PrintMavenAsDot` * Restore junit-bom * Update PrintMavenAsDotTest.java * Minimize indentation * Use the same bounds for labels as for edges
timtebeek
added a commit
that referenced
this pull request
Aug 12, 2025
…5897) * add reproducing tests * correct expectation and document that the DependencyInsight recipes match against resolved versions * Fix performance problem with RemoveUnusedProperties (#5895) * Fix performance problem with RemoveUnusedProperties - #5875 * Make the test values more descriptive * Stable label order for `PrintMavenAsDot` (#5893) * Stable label order for `PrintMavenAsDot` * Restore junit-bom * Update PrintMavenAsDotTest.java * Minimize indentation * Use the same bounds for labels as for edges * Match dot output in CI (#5898) * apply best practices --------- Co-authored-by: Tim te Beek <tim@moderne.io>
dcsekar
pushed a commit
to dcsekar/rewrite
that referenced
this pull request
Aug 18, 2025
* Stable label order for `PrintMavenAsDot` * Restore junit-bom * Update PrintMavenAsDotTest.java * Minimize indentation * Use the same bounds for labels as for edges
dcsekar
pushed a commit
to dcsekar/rewrite
that referenced
this pull request
Aug 18, 2025
…penrewrite#5897) * add reproducing tests * correct expectation and document that the DependencyInsight recipes match against resolved versions * Fix performance problem with RemoveUnusedProperties (openrewrite#5895) * Fix performance problem with RemoveUnusedProperties - openrewrite#5875 * Make the test values more descriptive * Stable label order for `PrintMavenAsDot` (openrewrite#5893) * Stable label order for `PrintMavenAsDot` * Restore junit-bom * Update PrintMavenAsDotTest.java * Minimize indentation * Use the same bounds for labels as for edges * Match dot output in CI (openrewrite#5898) * apply best practices --------- Co-authored-by: Tim te Beek <tim@moderne.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing some flaky tests lately, possibly following: