Skip to content

UpdateJavaCompatibility supports jvmToolchain shorthand #5820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2025

Conversation

jevanlingen
Copy link
Contributor

@jevanlingen jevanlingen commented Jul 29, 2025

What's changed?

What's your motivation?

Code like

kotlinVersion = '1.9.21'
 
kotlin {
  jvmToolchain(11)
}

was not picked up to be upgraded to a newer version.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@jevanlingen jevanlingen self-assigned this Jul 29, 2025
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Jul 29, 2025
@jevanlingen jevanlingen added bug Something isn't working recipe Requested Recipe labels Jul 29, 2025
@jevanlingen jevanlingen marked this pull request as draft July 29, 2025 08:24
@jevanlingen jevanlingen moved this from In Progress to Ready to Review in OpenRewrite Jul 29, 2025
@jevanlingen jevanlingen marked this pull request as ready for review July 29, 2025 09:17
Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

@timtebeek timtebeek changed the title UpdateJavaCompatibility supports jvmToolchain shorthand UpdateJavaCompatibility supports jvmToolchain shorthand Jul 29, 2025
@jevanlingen jevanlingen merged commit e0a394f into main Jul 29, 2025
2 checks passed
@jevanlingen jevanlingen deleted the UpdateJavaCompatibility-support-jvmToolchain branch July 29, 2025 11:07
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working recipe Requested Recipe
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants