-
Notifications
You must be signed in to change notification settings - Fork 451
MinimalViableSpacing recipe does not handle extends
correctly
#5768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MinimalViableSpacing recipe does not handle extends
correctly
#5768
Conversation
rewrite-java/src/main/java/org/openrewrite/java/format/MinimumViableSpacingVisitor.java
Outdated
Show resolved
Hide resolved
extends
correctly
rewrite-java-test/src/test/java/org/openrewrite/java/format/MinimumViableSpacingTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fixes here!
I wonder if we can now also remove this oddly added whitespace:
Line 168 in 6e66e18
c = c.getPadding().withExtends(c.getPadding().getExtends().withBefore(Space.format(" "))); |
It seems this takes care of the space before the |
Hmm; that's what line 77 does as well; guess that's a separate code path then. No need to change that here. |
What's changed?
implements
andextends