RPC: Add support for JavaType.Primitive
#5684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enums are a bit special in Java compared to many other programming languages, as they are proper objects and are allowed to have instance fields as well as implement interfaces. For normal enums the RPC mechanism only sends the enum constant's name. For `JavaType.Primitive` this doesn't quite work, because the RPC receiver currently assumes that "new" references are either transferred with a `value` or a `valueType`, but `JavaType.Primitive` instances get sent without either of these, because they have an `onChange` and a codec. Therefore, there is currently an exception for the `JavaType.Primitive` type in RPC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enums are a bit special in Java compared to many other programming languages, as they are proper objects and are allowed to have instance fields as well as implement interfaces. For normal enums the RPC mechanism only sends the enum constant's name. For
JavaType.Primitivethis doesn't quite work, because the RPC receiver currently assumes that "new" references are either transferred with avalueor avalueType, butJavaType.Primitiveinstances get sent without either of these, because they have anonChangeand a codec. Therefore, there is currently an exception for theJavaType.Primitivetype in RPC.