Skip to content

MavenPomDownloader: Use HEAD request in jarExistsForPomUri() #5675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025

Conversation

knutwannheden
Copy link
Contributor

@knutwannheden knutwannheden commented Jun 26, 2025

It seems like it should be enough to do a HEAD request in jarExistsForPomUri() and since this is for jar files this could make a difference.

It seems like it should be enough to do a HEAD request in `jarExistsForPomUri()`.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-core/src/main/java/org/openrewrite/internal/ManagedThreadLocal.java
    • lines 114-114
    • lines 184-184

@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Jun 26, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • rewrite-core/src/main/java/org/openrewrite/internal/ManagedThreadLocal.java
    • lines 115-115
    • lines 185-185

@knutwannheden knutwannheden merged commit d4353dc into main Jun 26, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Jun 26, 2025
@knutwannheden knutwannheden deleted the maven-jar-check branch June 26, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants