Skip to content

Refactoring, rename ObjectBindingDeclarations to ObjectBindingPattern #5626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Refactoring, rename ObjectBindingDeclarations to ObjectBindingPattern #5626

merged 1 commit into from
Jun 16, 2025

Conversation

greg-at-moderne
Copy link
Contributor

@greg-at-moderne greg-at-moderne commented Jun 16, 2025 •
edited
Loading

What's changed?

Renaming the Javascript's ObjectBindingDeclarations to ObjectBindingPattern.

What's your motivation?

That would make it both consistent with the ArrayBindingPattern name as well as with the name in the TS Compiler API.

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Jun 16, 2025
@greg-at-moderne greg-at-moderne self-assigned this Jun 16, 2025
@greg-at-moderne greg-at-moderne marked this pull request as ready for review June 16, 2025 08:04
@greg-at-moderne greg-at-moderne merged commit 32d30c0 into main Jun 16, 2025
2 checks passed
@greg-at-moderne greg-at-moderne deleted the greg-js-rename-ObjectBindingPattern branch June 16, 2025 08:04
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@greg-at-moderne greg-at-moderne

Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@greg-at-moderne