Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lombok support for java-11 #4769

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

amishra-u
Copy link
Contributor

What's changed?

Added lombok support for java-11

What's your motivation?

Enable type attribution for lombok generated methods for java 11.

Checklist

  • I've added unit tests to cover both positive and negative cases
    Lombok test already exist for java 17, enabled those test for java 11
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek
Copy link
Contributor

Thanks for the work done here to create parity between the Java 11 and 17 parsers @amishra-u ! As you've found there's still some issues we need to work out before we're comfortable repeating these patterns across parsers, and enable it by default:

Let's keep an eye on the discussion there and if we find a fix, apply that both for Java 17 and Java 11.

@timtebeek timtebeek marked this pull request as draft December 23, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants