Implement top-down matching for JsonPathMatcher
#4708
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-json/src/main/java/org/openrewrite/json/JsonPathMatcher.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
find(Cursor)andmatches(Cursor)methods were intended to be used to check if a given leaf node matches the JSON Path expression against a corresponding parent as starting point for the JSON path. As a result the expression had to be evaluated over and over again for each call to these methods, even though the evaluation results returns all matches each time.This PR updates the implementation so that the match results are stored as a cursor message for the root node against which the expression was matched. Then the matching often only needs to be done once and subsequent
find(), andmatches()calls will use that cached result.