Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ChangeType tests to adhere to testing framework #4673

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

Laurens-W
Copy link
Contributor

Anyone you would like to review specifically?

@timtebeek

Any additional context

Tests initially introduced in this PR

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Laurens-W Laurens-W requested a review from timtebeek November 14, 2024 13:40
@Laurens-W Laurens-W self-assigned this Nov 14, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Prevents incorrect patterns from spreading.

@Laurens-W Laurens-W merged commit e591869 into main Nov 14, 2024
2 checks passed
@Laurens-W Laurens-W deleted the polish-changetype-tests branch November 14, 2024 14:18
MBoegers pushed a commit to MBoegers/rewrite that referenced this pull request Dec 18, 2024
…te#4673)

* Polish tests

* Polish

---------

Co-authored-by: Tim te Beek <tim@moderne.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants