Do not wrap single active recipe & remove activateAll()

[timtebeek]

What's changed?

Remove activateAll() and do not wrap single active recipe into a new CompositeRecipe.

What's your motivation?

• Removes need for edge case handling unwrap in Pass in single recipe configuration options on the command line rewrite-maven-plugin#816
• Closer to what folks would expect in the simplest case: the directly instantiated Recipe, not an indirection wrapper.

Anything in particular you'd like reviewers to focus on?

The CompositeRecipe overrides a number of methods like the estimated time and data table descriptors. I think it's fine to skip this indirection, but an extra pair of eyes can't hurt.

rewrite/rewrite-core/src/main/java/org/openrewrite/config/CompositeRecipe.java

Lines 25 to 71 in 03c4584

	/**
	* A recipe that exists only to wrap other recipes.
	* Anonymous recipe classes aren't serializable/deserializable so use this, or another named type, instead
	*/
	@RequiredArgsConstructor
	public class CompositeRecipe extends Recipe {
	private final List<Recipe> recipeList;
	@Override
	public String getDisplayName() {
	return getName();
	}
	@Override
	public String getDescription() {
	return "A recipe that consists of a list of other recipes.";
	}
	@Override
	public Duration getEstimatedEffortPerOccurrence() {
	return null;
	}
	@Override
	public List<Recipe> getRecipeList() {
	return recipeList;
	}
	@Override
	public List<DataTableDescriptor> getDataTableDescriptors() {
	List<DataTableDescriptor> dataTableDescriptors = null;
	for (Recipe recipe : getRecipeList()) {
	List<DataTableDescriptor> dtds = recipe.getDataTableDescriptors();
	if (!dtds.isEmpty()) {
	if (dataTableDescriptors == null) {
	dataTableDescriptors = new ArrayList<>();
	}
	for (DataTableDescriptor dtd : dtds) {
	if (!dataTableDescriptors.contains(dtd)) {
	dataTableDescriptors.add(dtd);
	}
	}
	}
	}
	return dataTableDescriptors == null ? super.getDataTableDescriptors() : dataTableDescriptors;
	}
	}

Have you considered any alternatives or workarounds?

We can leave this indirection in for consistent handling no matter the number of active recipes.

Any additional context

• As discovered on Pass in single recipe configuration options on the command line rewrite-maven-plugin#816

[timtebeek]

@pstreef it seems like this indirection was masking missing descriptions in our test recipes; are you still ok with this updated PR?
I imagine we'll see this issue pop up some more downstream, although it seems like we already had similar unpacking on the Moderne side of things.