Gradle 9.2.0

[timtebeek]

Use this link to re-run the recipe: https://app.moderne.io/builder/Sh3Bg6DMd?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl

[greg-at-moderne]

1261 tests completed, 2 failed, 9 skipped

One is:

CleanupMockitoImportsTest > doNotRemoveMockitoImportsForKotlin() FAILED
    java.lang.IllegalStateException: LST contains missing or invalid type information
    MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
    /*~~(MethodInvocation type is missing or malformed)~~>*/org.mockito.Mockito.mock(Foo::class.java)

The other one is:

GradleUseJunitJupiterTest > tasksWithTypeTest() FAILED
    org.opentest4j.AssertionFailedError: [Unexpected result in "build.gradle":
[...]
    expected: 
      "plugins {
          id 'java'
      }
      tasks.withType(Test) {
          useJUnitPlatform()
      }"
     but was: 
      "plugins {
          id 'java'
      }
      tasks.withType(Test) {
      }
      tasks.withType(Test).configureEach {
          useJUnitPlatform()
      }"

[Laurens-W]

Second test failure is also due to type information on the Gradle API missing, tasks is of type java.lang.Object whilst the recipe expects org.gradle.api.tasks.TaskContainer

[timtebeek]

Ah that might be the Gradle 9 use of Groovy 4 not quite working well for us then I suppose; let me see if we can work around the issue.

[timtebeek]

Hmm; I've adjusted the failing test, but that already fails on the main branch as well:

    @Test
    void tasksWithTypeTest() {
        rewriteRun(
          //language=groovy
          buildGradle(
            """
              plugins {
                  id 'java'
              }
              tasks.withType(Test) {
              }
              """,
            """
              plugins {
                  id 'java'
              }
              tasks.withType(Test) {
                  useJUnitPlatform()
              }
              """,
            spec -> spec.beforeRecipe(cu -> {
                String string = TreeVisitingPrinter.printTree(cu);
                System.out.println(string);
                JavaType tasksType = ((J.MethodInvocation) cu.getStatements().getLast()).getSelect().getType();
                assertTrue(TypeUtils.isAssignableTo("org.gradle.api.tasks.TaskContainer", tasksType), tasksType.toString());
            })
          )
        );
    }

If I pin back the plugins on the main branch then the above passes;

plugins {
    id("org.openrewrite.build.recipe-library") version "2.5.6"
    id("org.openrewrite.build.moderne-source-available-license") version "2.5.6"
}