Added recipe to remove @VisibleForTesting annotation when used from production code

[JohannisK]

What's changed?

Added recipe to remove @VisibleForTesting annotation when used from production code

What's your motivation?

• Remove @VisibleForTesting if variable is accessed from production code #224

Anyone you would like to review specifically?

@jevanlingen
@Laurens-W
@greg-at-moderne

[JohannisK]

UseType<>() is not working here. It does work with the FQN, but not with "*.VisibleForTesting"

[timtebeek]

That might be a limitation in openrewrite/rewrite; ideally we'd detect the use of that annotation on the type, especially when we include implicit usages, but it appears we do not for now. Could require a fix upstream, but not pressing for now.

[timtebeek]

As discussed we're still seeing performance issues, likely because we're having to visit & determine the type of all references to classes, methods and fields to see if their target is annotated with VisibleForTesting. That's because we can not currently use any narrower precondition in our scanning visitor:
https://github.com/openrewrite/rewrite-testing-frameworks/pull/689/files#diff-7ad8934e882d4b7ce7b095083167e188aa0bb1b228249f8e76afab4da7e876d2R129

Perhaps it'd be an option to expand UsesType such that whenincludeImplicit = True, that it then also matches compilation units where references to targets annotated with the typePattern, but that would require changes to the parser to prepopulate TypesInUse, which could shift performance impact to the parser instead.