JMockit to Mockito Recipe - eq Support, Better Type Propagation, and Error Handling

[tinder-dthomson]

What's changed?

This PR includes these major changes:

• Expectations with raw values mixed with argument matchers should use eq
• Preserve the type information of Mockito any(Class) invocation arguments
• Fix infinite loop when rewriting Expectations block fails
• Major refactor of ArgumentMatchersRewriter to simplify logic and add clarity

What's your motivation?

Continue improving the recipe, make it easier to understand.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[github-actions]

Some suggestions could not be made:

• src/main/java/org/openrewrite/java/testing/junit5/TempDirNonFinal.java
  • lines 18-22

[timtebeek]

Nice improvements, thanks! Especially good to see the infinite loop resolved, as that had tripped up one or two users that I know. I also like the more specific eq matchers. Should help folks that want to migrate still.