Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddMissingTestBeforeAfterAnnotations is looking for both old and new annotations #445

Merged
merged 10 commits into from
Dec 22, 2023

Conversation

magicwerk
Copy link
Contributor

As discussed:

Recipe AddMissingTestBeforeAfterAnnotations is looking for both old and new annotations to support incremental migration

Moved recipe org.openrewrite.java.testing.junit5.LifecycleNonPrivate from
JUnit4to5Migration to JUnit5BestPractices

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! Added a very small change for readability; otherwise perfect.

@timtebeek timtebeek added bug Something isn't working enhancement New feature or request labels Dec 22, 2023
@timtebeek timtebeek merged commit 504a386 into openrewrite:main Dec 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants