Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes broken testcontainer dependencies after JUnit4to5Migration #430

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Fixes broken testcontainer dependencies after JUnit4to5Migration #430

merged 3 commits into from
Nov 22, 2023

Conversation

simonzn
Copy link
Contributor

@simonzn simonzn commented Nov 22, 2023 •
edited
Loading

  • Added a testcase for build errors due to missing Junit4 dependencies
  • Added workaround to JUnit4to5Migration: Undo the exclusion

Fixes #429

@timtebeek timtebeek self-requested a review November 22, 2023 19:16
@timtebeek timtebeek added the bug Something isn't working label Nov 22, 2023
@timtebeek
Copy link
Contributor

Creative solution to what's indeed an annoying problem; I'll allow it, thanks! :)

@timtebeek timtebeek merged commit 595a273 into openrewrite:main Nov 22, 2023
1 check passed
@simonzn simonzn deleted the bugfix/429-testcontainers-require-junit4 branch November 22, 2023 19:34
@timtebeek timtebeek mentioned this pull request Nov 25, 2023
Merged
This was referenced Feb 7, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timtebeek timtebeek Awaiting requested review from timtebeek

Assignees

@simonzn simonzn

Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JUnit4to5Migration excludes required dependency of testcontainers
2 participants
@simonzn @timtebeek