Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip test_ prefix from snake cased methods #247

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Strip test_ prefix from snake cased methods #247

merged 1 commit into from
Aug 15, 2022

Conversation

timtebeek
Copy link
Contributor

Small addition after exposure to new code base.

@timtebeek
Copy link
Contributor Author

Failure seems unrelated:

JUnitAssertTrueToAssertThatTest > singleStaticMethodNoMessage() FAILED

@pway99 pway99 merged commit 97e57e9 into openrewrite:main Aug 15, 2022
@pway99
Copy link
Contributor

pway99 commented Aug 15, 2022

Thanks @timtebeek,
I added another check to prevent renaming a method if there is another method having the same name as the new name.
feb241a

@timtebeek timtebeek deleted the strip_snake_case_test_prefix branch August 15, 2022 18:49
@timtebeek
Copy link
Contributor Author

Ah perfect, thanks! That's one of the issues I ran into as well; good to have that covered.

@pway99
Copy link
Contributor

pway99 commented Aug 15, 2022

Thanks for your effort to keep improving this one :)

@tkvangorder tkvangorder added this to the 1.27.0 milestone Sep 2, 2022
@tkvangorder tkvangorder added the bug Something isn't working label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timtebeek @pway99 @tkvangorder