Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid reserved keywords when stripping prefix from test methods #244

Merged
merged 1 commit into from
Aug 4, 2022
Merged

fix: Avoid reserved keywords when stripping prefix from test methods #244

merged 1 commit into from
Aug 4, 2022

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek commented Aug 4, 2022

Fixes #243. Not clear to me if meta annotations are immediately supported. Some insight or guidance there appreciated!

@timtebeek
Copy link
Contributor Author

At first glance the pipeline failure looks unrelated; perhaps a retry would help?

@jkschneider
Copy link
Member

At first glance the pipeline failure looks unrelated; perhaps a retry would help?

Agreed, we're having an intermittent problem with the underlying JDK.

@jkschneider jkschneider merged commit c42d091 into openrewrite:main Aug 4, 2022
@timtebeek timtebeek deleted the avoid_reserved_keywords branch August 4, 2022 13:14
@tkvangorder tkvangorder added this to the 1.26.1 milestone Aug 9, 2022
@tkvangorder tkvangorder added the bug Something isn't working label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

RemoveTestPrefix recipe must not rename methods to Java keywords
3 participants