Migrate anyCollectionOf/anyIterableOf to their no-arg replacements - #1100
Merged
Conversation
The method patterns for these two matchers declared no arguments, so they never matched the actual `(Class)` overloads that Mockito 4 removed. Fixes #1098
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mockito1to3Migrationalready convertedanyListOf/anySetOf/anyMapOf, and I've added tests covering both the static-import andMockito.-qualified forms (andorg.mockito.Matcherson Mockito 1.x) to confirm that.What was genuinely missing were the sibling matchers
anyCollectionOf(Class)andanyIterableOf(Class): their method patterns declared no arguments, so they never matched anything, and theClassargument was never dropped. Those are the only remainingArgumentMatchersmethods that Mockito 4 removed which the migration didn't handle.