Only RemoveTestPrefix for camel or snake case

Fixes #471
openrewrite · Jan 24, 2024 · b5b0c84 · b5b0c84
1 parent 6b5fd4f
commit b5b0c84
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/src/main/java/org/openrewrite/java/testing/cleanup/RemoveTestPrefix.java b/src/main/java/org/openrewrite/java/testing/cleanup/RemoveTestPrefix.java
@@ -84,6 +84,7 @@ public J.MethodDeclaration visitMethodDeclaration(J.MethodDeclaration method,
             int nameLength = simpleName.length();
             if (nameLength < 5
                     || !simpleName.startsWith("test")
+                    || !(simpleName.charAt(4) == '_' || Character.isUpperCase(simpleName.charAt(4)))
                     || TypeUtils.isOverride(method.getMethodType())
                     || !hasJUnit5MethodAnnotation(method)) {
                 return m;

diff --git a/src/test/java/org/openrewrite/java/testing/cleanup/RemoveTestPrefixTest.java b/src/test/java/org/openrewrite/java/testing/cleanup/RemoveTestPrefixTest.java
@@ -18,6 +18,7 @@
 import org.junit.jupiter.api.Test;
 import org.openrewrite.DocumentExample;
 import org.openrewrite.InMemoryExecutionContext;
+import org.openrewrite.Issue;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.test.RecipeSpec;
 import org.openrewrite.test.RewriteTest;
@@ -292,4 +293,27 @@ static Stream<Arguments> testMyDoSomethingLogic() {
           )
         );
     }
+
+    @Test
+    @Issue("https://github.com/openrewrite/rewrite-testing-frameworks/issues/471")
+    void ignoreTestingAsPrefix() {
+        //language=java
+        rewriteRun(
+          java(
+            """
+              import org.junit.jupiter.api.Test;
+
+              class ATest {
+                  @Test
+                  void testingEnvironment() {
+                  }
+
+                  @Test
+                  void tests() {
+                  }
+              }
+              """
+          )
+        );
+    }
 }