Skip to content

Commit

Permalink
Add Mockito best practices to clear out MockitoSettings
Browse files Browse the repository at this point in the history
Fixes #589
  • Loading branch information
timtebeek committed Sep 3, 2024
1 parent 2621b64 commit 996709b
Show file tree
Hide file tree
Showing 2 changed files with 85 additions and 0 deletions.
12 changes: 12 additions & 0 deletions src/main/resources/META-INF/rewrite/mockito.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,18 @@
#
---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.testing.mockito.MockitoBestPractices
displayName: Mockito best practices
description: .
tags:
- testing
- mockito
recipeList:
- org.openrewrite.java.testing.mockito.Mockito1to5Migration
- org.openrewrite.java.RemoveAnnotation:
annotationPattern: "@org.mockito.junit.jupiter.MockitoSettings(strictness=org.mockito.quality.Strictness.WARN)"
---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.testing.mockito.Mockito1to5Migration
displayName: Mockito 5.x upgrade
description: Upgrade Mockito from 1.x to 5.x.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
package org.openrewrite.java.testing.mockito;

import org.junit.jupiter.api.Test;
import org.openrewrite.DocumentExample;
import org.openrewrite.InMemoryExecutionContext;
import org.openrewrite.java.JavaParser;
import org.openrewrite.test.RecipeSpec;
import org.openrewrite.test.RewriteTest;

import static org.openrewrite.java.Assertions.java;

class RemoveMockitoSettingsTest implements RewriteTest {

@Override
public void defaults(RecipeSpec spec) {
spec
.parser(JavaParser.fromJavaVersion()
.classpathFromResources(new InMemoryExecutionContext(),
"mockito-core", "mockito-junit-jupiter", "junit-jupiter-api"))
.recipeFromResource("/META-INF/rewrite/mockito.yml", "org.openrewrite.java.testing.mockito.MockitoBestPractices");
}

@Test
@DocumentExample
void removeMockitoSettings() {
rewriteRun(
//language=java
java(
"""
import org.mockito.junit.jupiter.MockitoSettings;
import org.mockito.quality.Strictness;
@MockitoSettings(strictness = Strictness.WARN)
class A {}
""",
"""
class A {}
"""
)
);
}

@Test
void removeMockitoSettingsFullyQualified() {
rewriteRun(
//language=java
java(
"""
import org.mockito.junit.jupiter.MockitoSettings;
@MockitoSettings(strictness = org.mockito.quality.Strictness.WARN)
class A {}
""",
"""
class A {}
"""
)
);
}

@Test
void retainMisMatchedArgument() {
rewriteRun(
//language=java
java(
"""
import org.mockito.junit.jupiter.MockitoSettings;
import org.mockito.quality.Strictness;
@MockitoSettings(strictness = Strictness.LENIENT)
class A {}
"""
)
);
}
}

0 comments on commit 996709b

Please sign in to comment.