Add BufferedWriterCreation recipe
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is currently failing. It seems that |
|
Also, waiting on openrewrite/rewrite#4015 to land too for this PR |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/staticanalysis/SimplifyConstantTernaryExecution.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/SimplifyConstantTernaryExecution.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/BufferedWriterCreation.java
Outdated
Show resolved
Hide resolved
- BufferedWriterCreation - SimplifyConstantTernaryExecution Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
JLLeitschuh
force-pushed
the
feat/JLL/buffered-writer-creation-and-simplify-ternary
branch
from
1ef0e73
to
56a8440
Compare
src/main/java/org/openrewrite/staticanalysis/SimplifyConstantTernaryExecution.java
Outdated
Show resolved
Hide resolved
JLLeitschuh
commented
Feb 17, 2024
src/test/java/org/openrewrite/staticanalysis/SimplifyConstantTernaryExecutionTest.java
Outdated
Show resolved
Hide resolved
timtebeek
changed the title
src/main/java/org/openrewrite/staticanalysis/BufferedWriterCreation.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/BufferedWriterCreation.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/BufferedWriterCreation.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/BufferedWriterCreation.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/staticanalysis/SimplifyConstantTernaryExecution.java
Outdated
Show resolved
Hide resolved
timtebeek
added a commit
to openrewrite/rewrite
that referenced
this pull request
Oct 27, 2024
timtebeek
added a commit
to openrewrite/rewrite
that referenced
this pull request
Oct 27, 2024
* Simplify constant ternary expressions too - For openrewrite/rewrite-static-analysis#258 * Show additional cases covered
timtebeek
changed the title
BufferedWriterCreation recipe
|
Thanks both! Took me a little while to get to, but I've pushed up a few small improvements to rewrite & rewrite-templating to narrow down the changes here to just a regular Refaster recipe, such that other recipes can also benefit from those improvements: |
timtebeek
approved these changes
Oct 27, 2024
timtebeek
added a commit
to openrewrite/rewrite-java-security
that referenced
this pull request
Oct 27, 2024
|
Also added to Java security best practices: openrewrite/rewrite-java-security@9d9c9ff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jonathan Leitschuh Jonathan.Leitschuh@gmail.com
What's your motivation?
More recipes, more better?
Anything in particular you'd like reviewers to focus on?
There seems to be a bug in
autoFormatwhere theJ.Literalisn't having it's prefix padding removed.Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist