Skip to content

The quick fix for the tests for Jaxws Dependencies #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

The quick fix for the tests for Jaxws Dependencies #809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2fb859
The quick fix for the tests for Jaxws Dependencies
steve-aom-elliott Aug 5, 2025
ede0bd6
Fixing separate test that broke when candidate were updated
steve-aom-elliott Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/main/resources/META-INF/rewrite/java-version-11.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,6 @@ recipeList:
newGroupId: jakarta.xml.ws
newArtifactId: jakarta.xml.ws-api
newVersion: 2.3.x
- org.openrewrite.maven.ChangeManagedDependencyGroupIdAndArtifactId:
oldGroupId: javax.xml.ws
oldArtifactId: jaxws-api
newGroupId: jakarta.xml.ws
newArtifactId: jakarta.xml.ws-api
newVersion: 2.3.x
# Add the jakarta JAXB artifact if it is missing but a project uses types in either javax.jws or javax.xml.ws
- org.openrewrite.java.dependencies.AddDependency:
groupId: jakarta.xml.ws
Expand All @@ -168,11 +162,11 @@ recipeList:
- org.openrewrite.maven.RemoveRedundantDependencyVersions:
groupPattern: jakarta.xml.ws
artifactPattern: "*"
onlyIfVersionsMatch: true
onlyIfManagedVersionIs: EQ
- org.openrewrite.maven.RemoveRedundantDependencyVersions:
groupPattern: com.sun.xml.ws
artifactPattern: "*"
onlyIfVersionsMatch: true
onlyIfManagedVersionIs: EQ
---
type: specs.openrewrite.org/v1beta/recipe
name: org.openrewrite.java.migrate.InternalBindPackages
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/openrewrite/java/migrate/UpdateSdkManTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ void nonNumericalVersionPart() {
java=11.0.25.fx-zulu
""",
"""
java=17.0.15.fx-zulu
java=17.0.16.fx-zulu
""",
spec -> spec.path(".sdkmanrc")
)
Expand Down
12 changes: 8 additions & 4 deletions src/test/java/org/openrewrite/java/migrate/javax/AddJaxwsDependenciesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,13 @@ void removeReferenceImplementationRuntime() {
}

dependencies {
implementation "com.sun.xml.ws:jaxws-rt:%s"
compileOnly "com.sun.xml.ws:jaxws-rt:%s"

implementation "jakarta.xml.ws:jakarta.xml.ws-api:%s"

testImplementation "com.sun.xml.ws:jaxws-rt:%s"
}
""".formatted(rtVersion, wsApiVersion);
""".formatted(rtVersion, wsApiVersion, rtVersion);
})
),
pomXml(
Expand Down Expand Up @@ -299,11 +301,13 @@ void renameAndUpdateApiAndRuntime() {
}

dependencies {
implementation "com.sun.xml.ws:jaxws-rt:%s"
compileOnly "com.sun.xml.ws:jaxws-rt:%s"

implementation "jakarta.xml.ws:jakarta.xml.ws-api:%s"

testImplementation "com.sun.xml.ws:jaxws-rt:%s"
}
""".formatted(rtVersion, wsApiVersion);
""".formatted(rtVersion, wsApiVersion, rtVersion);
})
),
pomXml(
Expand Down