Skip to content

Conversation

Jenson3210
Copy link
Contributor

@Jenson3210 Jenson3210 commented Jun 23, 2025

What's changed?

No longer throw exception -> results in error.
Just only perform migration in known set of types (added 2 more types also)

What's your motivation?

This exception was causing the repos to "error" out.

Anyone you would like to review specifically?

@timtebeek

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Jun 23, 2025
@Jenson3210 Jenson3210 moved this from In Progress to Ready to Review in OpenRewrite Jun 23, 2025
@Jenson3210 Jenson3210 self-assigned this Jun 23, 2025
@Jenson3210 Jenson3210 requested a review from timtebeek June 23, 2025 08:27
@Jenson3210 Jenson3210 added the bug Something isn't working label Jun 23, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/java/migrate/util/MigrateCollectionsSingletonMapTest.java
    • lines 108-108

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/java/migrate/util/MigrateCollectionsSingletonMapTest.java
    • lines 108-108

…uctToSwitchTest.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/test/java/org/openrewrite/java/migrate/util/MigrateCollectionsSingletonMapTest.java
    • lines 108-108

@Jenson3210 Jenson3210 merged commit ac1e235 into main Jun 23, 2025
2 checks passed
@Jenson3210 Jenson3210 deleted the fix-generic-class-and-arraytypes branch June 23, 2025 08:46
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants