feat: Prevent migration of singletonMap with null value or null key #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
The rule
org.openrewrite.java.migrate.util.MigrateCollectionsSingletonMap
also migrated the following cases:to
which leads to a NullPointerException
What's your motivation?
There is a closed issue #571 where it was even mentioned in the comments to apply the same to maps, but the changes were not done in the previous PR.
Checklist