Pattern matching for instanceof
#764
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/java/migrate/lang/PatternMatchingWithInstanceOf.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/lang/PatternMatchingWithInstanceOfTest.java
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lang/PatternMatchingWithInstanceOf.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
reviewed
Jun 17, 2025
| return Objects.requireNonNullElse(obj, "default"); | ||
| } | ||
| } | ||
| language: java |
There was a problem hiding this comment.
Quick FYI: local recipe runs and platform recipe runs disagree about the order, but are each internally consistent. No idea why, but best to limit your changes to new additions if you're kind enough to run these locally. (No need to update, just FYI)
|
Closing in favour of the one brought by @knutwannheden. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added a recipe for pattern matching in Instace of if-checks.
I am creating as draft due to the JavaTemplate usage here.
What's your motivation?
Needed for the switch pattern matching to get cleaner results:
Checklist