Add only declarable Gradle jax-ws runtime dependencies #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevanlingen
commented
Jun 13, 2025
src/main/java/org/openrewrite/java/migrate/javax/AddJaxwsRuntime.java
Outdated
Show resolved
Hide resolved
|
@jevanlingen there was a perhaps related report in #760 that might help you reproduce the issue; could be worth briefly seeing if that indeed helps, or is fixed now. |
|
@timtebeek, yeah awesome, this is exactly the case this PR does fix! |
Jenson3210
reviewed
Jun 13, 2025
src/main/java/org/openrewrite/java/migrate/javax/AddJaxwsRuntime.java
Outdated
Show resolved
Hide resolved
Jenson3210
approved these changes
Jun 13, 2025
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
For the
AddJaxwsRuntimeGradlerecipe the resolution-only dependencies are no longer added.