Pick better SDKMan versions #754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's your motivation?
Right now we pick an incorrect distribution for Zulu upgrades to Java 17.
There's are the versions that are available:
We ought to pick
17.0.15-zulu
as the highest version number, with a matching (non fx/crac) distribution.In practice, we pick 17.0.13.crac-zulu as the first match here:
rewrite-migrate-java/src/main/java/org/openrewrite/java/migrate/UpdateSdkMan.java
Lines 96 to 98 in 962b76c