-
Notifications
You must be signed in to change notification settings - Fork 101
Refine switch cases #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine switch cases #749
Conversation
src/test/java/org/openrewrite/java/migrate/lang/RefineSwitchCasesTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lang/RefineSwitchCases.java
Outdated
Show resolved
Hide resolved
…ses.java Co-authored-by: Jacob van Lingen <jacobvanlingen@hotmail.com>
src/main/java/org/openrewrite/java/migrate/lang/RefineSwitchCases.java
Outdated
Show resolved
Hide resolved
…ses.java Co-authored-by: Jacob van Lingen <jacobvanlingen@hotmail.com>
src/main/java/org/openrewrite/java/migrate/lang/RefineSwitchCases.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/lang/RefineSwitchCases.java
Outdated
Show resolved
Hide resolved
@timtebeek would you want any further review? Or can I go ahead and do the necessary to merge (adapt the declarative yaml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see, thanks! I've applied some small changes & fixes, mostly to avoid problems with already guarded cases or unexpected elements in conditionals, and to keep the formatting as close to the original as it was by taking out explicitly overridden whitespace:
def387f...093b16d
I've also ran this against Apache locally using the CLI, but did not see any changes there. We can try again using the platform after this is merged and deployed.
Ran at scale and found some slight imperfections; fixed with ed6194c and figured share that here in case it applies to the others as well. |
What's changed?
Cutting up the task at hand in multiple smaller PR's for better insights, risk assessment...
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist