Skip to content

Conversation

Jenson3210
Copy link
Contributor

What's changed?

Cutting up the task at hand in multiple smaller PR's for better insights, risk assessment...

  • RefineSwitchCases

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Jun 2, 2025
@Jenson3210 Jenson3210 self-assigned this Jun 3, 2025
@Jenson3210 Jenson3210 added the recipe Recipe requested label Jun 3, 2025
…ses.java

Co-authored-by: Jacob van Lingen <jacobvanlingen@hotmail.com>
…ses.java

Co-authored-by: Jacob van Lingen <jacobvanlingen@hotmail.com>
@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Jun 4, 2025
@Jenson3210
Copy link
Contributor Author

@timtebeek would you want any further review? Or can I go ahead and do the necessary to merge (adapt the declarative yaml)

Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see, thanks! I've applied some small changes & fixes, mostly to avoid problems with already guarded cases or unexpected elements in conditionals, and to keep the formatting as close to the original as it was by taking out explicitly overridden whitespace:
def387f...093b16d

I've also ran this against Apache locally using the CLI, but did not see any changes there. We can try again using the platform after this is merged and deployed.

@timtebeek timtebeek merged commit 97410ab into main Jun 14, 2025
2 checks passed
@timtebeek timtebeek deleted the refine_switch_cases branch June 14, 2025 16:38
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Jun 14, 2025
@timtebeek
Copy link
Member

Ran at scale and found some slight imperfections; fixed with ed6194c and figured share that here in case it applies to the others as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java 21+ recipe Recipe requested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants