-
Notifications
You must be signed in to change notification settings - Fork 101
Create Faces 3.0 migration #742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ould be happening
@evie-lau first let me say you are correct about these SHOULD be in 3.0. However the reason I put them in 4.0 is that 3.0 was never meant to be a thing. 3.0 was where vendors were supposed to test their javax to jakarta migration. Nobody should be running production on EE9 or faces 3.0. In fact both the mojarra and MyFaces teams have already closed their 3.0 branches and recommends anyone should be using either 2.3 or 4.0 Faces version So to not promote 3.0 any more than it should I chose to make those conversions in Faces 4.0. I hope that makes sense. |
@melloware thank you for your explanation. That makes a lot of sense now. Is that to also say that the jakarta-ee-9 recipe shouldn't really be used? Currently that EE9 recipe fails to migrate a few things including some |
I am almost thinking we dump the EE9 recipe as no one should really be migrating to 9. 10 is the official release |
@timtebeek thoughts on refactoring this to get rid of EE9 entirely? |
I feel like since EE9 is still a valid released spec, it should still be allowed as a migration target, and should be fixed to migrate correctly. |
I will leave it up to Moderne but my peace has been said that EE9 is not really a release anyone should be migrating to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks both! Very helpful context to understanding the changes here, and the wider context about EE9 vs EE10. I think we're fine to keep the EE9 recipe around, even if the goal ought to be EE10. Helps keep the recipes organized, and ensures folks that already used some of the existing recipes can continue to reference those.
Jakarta EE9 migration is incomplete, does not migrate JSF 2.3 to Jakarta Faces, and leaves behind a lot of
javax
references and packages from EE8 or prior.Most of the migrations currently in the Faces 4 EE10 migration should actually happen during the EE9 Faces 3 migration.
What's changed?
javax
tojakarta
changes moved to new Faces 3.0 migration recipeWhat's your motivation?
Anything in particular you'd like reviewers to focus on?
I've added a few TODO comments on some recipe groups that I'd like to be checked over for input.
Anyone you would like to review specifically?
@melloware it seems you wrote most of the Faces migration, and I'd love to have your input on this.
@TeamModerne - please review the discussion below regarding EE9/Faces 3.0 migration
Checklist