Skip to content

Conversation

bryceatmoderne
Copy link
Contributor

@bryceatmoderne bryceatmoderne commented May 22, 2025

What's changed?

Made org.openrewrite.java.migrate.lombok.log.LogVisitor public

What's your motivation?

Workaround the following when loading rewrite-devcenter recipes:

class org.openrewrite.java.migrate.lombok.log.UseLog$1 cannot access its superclass org.openrewrite.java.migrate.lombok.log.LogVisitor (org.openrewrite.java.migrate.lombok.log.UseLog$1 is in unnamed module of loader io.moderne.recipe.RecipeClassLoader @71f96dfb; org.openrewrite.java.migrate.lombok.log.LogVisitor is in unnamed module of loader 'app')

Anything in particular you'd like reviewers to focus on?

Alternative solutions

Anyone you would like to review specifically?

@pstreef

Have you considered any alternatives or workarounds?

No

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

…id class loader access issues when loading recipe
@bryceatmoderne bryceatmoderne requested a review from pstreef May 22, 2025 02:36
@bryceatmoderne bryceatmoderne self-assigned this May 22, 2025
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite May 22, 2025
@bryceatmoderne bryceatmoderne moved this from In Progress to Ready to Review in OpenRewrite May 22, 2025
Copy link
Contributor

@pstreef pstreef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping we could make it work without this, but I'm also happy to make that a future us problem

@bryceatmoderne bryceatmoderne merged commit 5295c75 into main May 22, 2025
1 of 2 checks passed
@bryceatmoderne bryceatmoderne deleted the make-lombok-logvisitor-public branch May 22, 2025 14:01
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants