Insert <shared-cache-mode> before <properties> to ensure correct schema order

[Avneesh-Dubey]

What's changed?

Added logic to insert <shared-cache-mode> before <properties> and added the test case for it.

Anything in particular you'd like reviewers to focus on?

After making the changes to recipe the tests were not passing as they were not taking accepting comments, all the tests start to pass once I removed the comments in the test cases therefore I would like a review on it.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[rlsanders4]

The changes are looking good Avneesh. I just have a few small comments.

[rlsanders4]

Looks good to me. It would be good to also get a review from the rewrite team before merging.

[timtebeek]

Thanks all! Looks like this indeed would solve

• Application does not deploy on Payara 6 / EclipseLink after EE10 migration due to error in persistence.xml #689

We'll get this reviewed and merged.

[timtebeek]

Thanks both! I've swapped in ListUtils.insertInOrder for a more expressive fix here, as compared to the list wrangling that was there before. Great to see this fixed!