Skip to content

Conversation

evie-lau
Copy link
Contributor

@evie-lau evie-lau commented May 19, 2025

What's changed?

  • Use provided scope in the Jakarta XML WS recipe
  • Handle more upgrade scenarios correctly

What's your motivation?

#730

Anything in particular you'd like reviewers to focus on?

Unsure if the jaxws-rt dependency is still needed when upgrading to EE9. Maybe it could be removed? but for now making it provided scope similar to what gets added via

- org.openrewrite.java.migrate.javax.AddJaxwsRuntime

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@evie-lau evie-lau self-assigned this May 19, 2025
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite May 19, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/resources/META-INF/rewrite/examples.yml
    • lines 997-1007
    • lines 1036-1042

@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite May 19, 2025
@timtebeek
Copy link
Member

There's some unrelated test failures that we're still flushing out; we'll merge this either way. Thanks again!

@timtebeek timtebeek merged commit cb161e6 into openrewrite:main May 19, 2025
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite May 19, 2025
@timtebeek timtebeek added the bug Something isn't working label May 19, 2025
@evie-lau evie-lau deleted the jaxws-rt branch May 19, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Duplicate jaxws-rt dependency when running Java8toJava11 then JakartaEE9

2 participants