Skip to content

Conversation

timtebeek
Copy link
Member

@timtebeek timtebeek self-assigned this May 19, 2025
@timtebeek timtebeek added the bug Something isn't working label May 19, 2025
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite May 19, 2025
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite May 19, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/resources/META-INF/rewrite/examples.yml
    • lines 997-1007
    • lines 1036-1042

@timtebeek
Copy link
Member Author

Seeing unrelated flaky test, possibly because of (or at least since) parallel test runs:

UpdateBeanManagerMethodsTest > fireEventWithClassifiers() FAILED
    java.lang.IllegalStateException: LST contains missing or invalid type information
    MethodDeclaration->Block->ClassDeclaration->CompilationUnit
    /*~~(MethodDeclaration type is missing or malformed)~~>*/void one(BeanManager beanManager, /*~~(Identifier type is missing or malformed)~~>*/BeforeBeanDiscovery beforeBeanDiscovery, Annotation classifier) {
        beanManager.fireEvent(/*~~(Identifier type is missing or malformed)~~>*/beforeBeanDiscovery, classifier);
    }
    Identifier->VariableDeclarations->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
    /*~~(Identifier type is missing or malformed)~~>*/BeforeBeanDiscovery
    Identifier->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
    /*~~(Identifier type is missing or malformed)~~>*/beforeBeanDiscovery
    MethodDeclaration->Block->ClassDeclaration->CompilationUnit
    /*~~(MethodDeclaration type is missing or malformed)~~>*/void two(BeanManager beanManager, /*~~(Identifier type is missing or malformed)~~>*/BeforeBeanDiscovery beforeBeanDiscovery, Annotation classifier) {
        beanManager.fireEvent(/*~~(Identifier type is missing or malformed)~~>*/beforeBeanDiscovery, classifier, classifier);
    }
    Identifier->VariableDeclarations->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
    /*~~(Identifier type is missing or malformed)~~>*/BeforeBeanDiscovery
    Identifier->MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
    /*~~(Identifier type is missing or malformed)~~>*/beforeBeanDiscovery
    https://docs.openrewrite.org/reference/faq#im-seeing-lst-contains-missing-or-invalid-type-information-in-my-recipe-unit-tests-how-to-resolve
        at org.openrewrite.java.Assertions.assertValidTypes(Assertions.java:125)
        at org.openrewrite.java.Assertions.validateTypes(Assertions.java:62)
        at org.openrewrite.java.Assertions$$Lambda/0x00007f67941b7dd8.accept(Unknown Source)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:303)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:130)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:125)
        at org.openrewrite.java.migrate.jakarta.UpdateBeanManagerMethodsTest.fireEventWithClassifiers(UpdateBeanManagerMethodsTest.java:103)

@timtebeek
Copy link
Member Author

Also seeing another failure after adding openrewrite/rewrite@944f23e ; again seeing no reason why that would fail now when it worked before we did parallel runs.

Caused by: java.lang.IllegalArgumentException: Could not parse as Java:	
import java.time.ZonedDateTime;	
import org.openrewrite.java.internal.template.__M__;	
import org.openrewrite.java.internal.template.__P__;	
class Template {	
Object o =	
/*__TEMPLATE__*/ZonedDateTime.now()/*__TEMPLATE_STOP__*/	
;	
}	

@timtebeek timtebeek merged commit d8e4990 into main May 19, 2025
1 of 2 checks passed
@timtebeek timtebeek deleted the recursive-package-change-last branch May 19, 2025 18:41
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

1 participant