StringFormatted should not wrap first argument by default in Java 17 upgrade #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
deleted the
string-formatted-not-for-string-concatenation-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Made the wrapping optional but enabled when run directly, but disabled in the Java 17 upgrade recipe.
Also moved this recipe to after the change that introduces text blocks, such that we can pick those up still.
What's your motivation?
Have you considered any alternatives or workarounds?
We could have made the optional false by default, but then it's harder for folks to discover and run.
Any additional context
We use the same pattern for introducing text blocks; with a flag set to false when included in the Java 17 migration.