Skip to content

Conversation

amishra-u
Copy link
Contributor

@amishra-u amishra-u commented Dec 2, 2024

What's changed?

Fixed these bugs in JodaTime to JavaTime migration recipe..

  1. Updated the code to handle scenarios where variable declarations, such as lambda parameters, might lack a type expression.
  2. Recipe was throwing NPE for any variable declaration of unimplemented type.
  3. Fixed an issue where the updated assignment expression was incorrectly passed instead of the original one to fetch the migration template.
  4. Javadoc may not always have valid method reference. Skipped migration of reference in javadoc.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek
Copy link
Member

Thanks again @amishra-u !

@timtebeek timtebeek merged commit 05b8264 into openrewrite:main Dec 2, 2024
2 checks passed
@amishra-u
Copy link
Contributor Author

Thanks again @amishra-u !

Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants