Fixed version Typo in JavaxWsToJakartaWs Recipe #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thanks a lot for pointing this out! I found an additional to cases, but it appears I'm not allowed to push to this pull request branch, so I'll fix those on main. Also did a quick scan across all OpenRewrite projects; luckily only this file seemed affected: Still might be a good reason to add validation that there's no unmatched options, as this one could take a while to spot. 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo in JavaxWsToJakartaWs recipe
What's changed?
The version option changed to newVersion in the org.openrewrite.java.migrate.jakarta.JavaxWsToJakartaWs recipe.
What's your motivation?
While migrating to Jakarta with the org.openrewrite.java.migrate.jakarta.JakartaEE10 recipe I noticed something strange. The version of my previously used dependency javax.ws.rs didn't change. So I started looking around and found probably a typo.