Skip to content

Conversation

BhavanaPidapa
Copy link
Contributor

What's changed?

image

What's your motivation?

I used org.openrewrite.java.migrate.RemoveMethodInvocation for the recipe ThreadStopDestroy

Anyone you would like to review specifically?

@cjobinabo @timtebeek

Have you considered any alternatives or workarounds?

Since it was not possible to test the recipe completely. I created sample files, created a local plugin using
./gradlew publishToMavenLocal then ran it in the Java8 Sample App using mvn rewrite:dryRun

Attaching the rewrite.patch file
rewrite.patch

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek timtebeek requested a review from cjobinabo June 25, 2024 07:01
@timtebeek timtebeek changed the title Java11 Recipe ThreadStopDestroy Remove Thread.destroy() and Thread.stop(Throwable) Jun 25, 2024
@timtebeek timtebeek added the recipe Recipe requested label Jun 25, 2024
Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for covering this one. I've added a few small polishing changes that I hope you'll agree with. Ready to merge when @cjobinabo agrees.

@timtebeek timtebeek merged commit 6e212fd into openrewrite:main Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

recipe Recipe requested

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants