Skip to content

Conversation

melloware
Copy link
Contributor

@melloware melloware commented Jun 14, 2024

What's changed?

  • change namespaces from xmlns:p="http://primefaces.org/ui" to xmlns:p="primefaces"
  • Bump PF version to 14.X

@timtebeek
Copy link
Member

Welcome back & thanks! One test failure it seems, but looks like we could fix that

UpgradeFacesOpenSourceLibrariesTest > changeVersionAndAddClassfier() FAILED
    java.util.NoSuchElementException: No value present
        at java.base/java.util.Optional.orElseThrow(Optional.java:377)
        at org.openrewrite.java.migrate.jakarta.UpgradeFacesOpenSourceLibrariesTest.lambda$changeVersionAndAddClassfier$1(UpgradeFacesOpenSourceLibrariesTest.java:55)
        at org.openrewrite.java.migrate.jakarta.UpgradeFacesOpenSourceLibrariesTest$$Lambda$1308/0x00007fc0cc7ba230.apply(Unknown Source)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:503)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:133)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:128)
        at org.openrewrite.java.migrate.jakarta.UpgradeFacesOpenSourceLibrariesTest.changeVersionAndAddClassfier(UpgradeFacesOpenSourceLibrariesTest.java:34)

@melloware
Copy link
Contributor Author

Looking.

Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for coming back with the fixes in tandem with the new release! :)

@timtebeek timtebeek added the recipe Recipe requested label Jun 14, 2024
@timtebeek timtebeek merged commit 422f83c into openrewrite:main Jun 14, 2024
@melloware melloware deleted the primefaces14 branch June 14, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

recipe Recipe requested

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants