Skip to content

Fix #478: EE bean validation.properties and SPI #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2024
Merged

Fix #478: EE bean validation.properties and SPI #479

merged 1 commit into from
May 18, 2024

Conversation

melloware
Copy link
Contributor

Fix #478: EE bean validation.properties and SPI

  • Renames javax.validation.ConstraintValidator to jakarta.validation.ConstraintValidator
  • Finds all ValidationMessages.properties including lang specific like ValidationMessages_en.properties and replaces javax. with jakarta.

@timtebeek timtebeek self-requested a review May 18, 2024 20:51
@timtebeek timtebeek added the recipe Recipe requested label May 18, 2024
timtebeek
timtebeek approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see how quickly you added these after they were reported. Thanks a lot yet again!

@timtebeek timtebeek merged commit d1ff645 into openrewrite:main May 18, 2024
@melloware melloware deleted the bean-validator branch May 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timtebeek timtebeek timtebeek approved these changes

Assignees

@melloware melloware

Labels

recipe Recipe requested

Projects

OpenRewrite
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to jakarta.validation does not update META-INF/services/javax.validation.ConstraintValidator

2 participants

@melloware @timtebeek