Skip to content

Conversation

cjobinabo
Copy link
Contributor

What's changed?

This pulls out some parameterized recipes from the root recipe lists to enable the ability to invoke these recipes directly.

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@cjobinabo cjobinabo self-assigned this May 17, 2024
github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for breaking these up and making them more explicit what we do.

Two small suggestions that I think came from copying between these files, as we don't update dependencies in two of the three recipes. (Unless we should)

@timtebeek timtebeek added the recipe Recipe requested label May 17, 2024
cjobinabo and others added 2 commits May 17, 2024 12:42
Co-authored-by: Tim te Beek <tim@moderne.io>
Co-authored-by: Tim te Beek <tim@moderne.io>
@timtebeek timtebeek merged commit 64f8669 into openrewrite:main May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

recipe Recipe requested

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants