fix: Add Jakarta XML WS API when using javax.xml.ws #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- jakarta.xml.ws-api contains packages javax.jws and javax.xml.ws, so we need to add the dependency when either is in use. - Fixed and re-enabled AddJaxwsDependenciesTest by correcting the after specs to line up with expected results
timtebeek
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Running the Java 11 migration against my code base resulted in jakarta.xml.ws-api not being added to some projects that only used classes in javax.xml.ws
Anything in particular you'd like reviewers to focus on?
Validate the revised expected results for AddJaxwsDependenciesTest line up with expectations
Checklist