Recipe to remove Thread.countStackFrames().

[ranuradh]

What's changed?

Recipe :org.openrewrite.java.migrate.DeprecatedCountStackFramesMethod

Any additional context

Thread.countStackFrames()has been removed in Java SE 14 and has been changed in this release to unconditionally throwUnsupportedOperationException`. This recipe removes the usage of this method in your application as long as the method is not assigned to a variable.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Hi @ranuradh ; I'm still out for another couple weeks. Probably good to tag Knut for review once @cjobinabo has gone over the changes.

[cjobinabo]

You probably meant for \\\"0\\\" to be \"0\". But the description it's is actually misleading. Thread.countStackFrames() was not replaced with Integer.valueOf("0"). Integer.valueOf("0") is just a placeholder that allows us to safely remove Thread.countStackFrames(). As I mentioned earlier when we spoke last week, we will need to update this recipe to have a comment before or after the updated code to let the user know they should review and remove the Integer.valueOf("0") placeholder. @knutwannheden, do you have any examples you could point Anu to on how this comment can be provided, or perhaps a better idea of how Thread.countStackFrames() could be safely removed?

[ranuradh]

Not sure how the extra \ got in the description, removed that in the next commit. Based on our conversation I assumed that for now we will be using this format for the recipe, hence added the line "The updated line is dead code and should be eventually removed." I can wait for what @knutwannheden has to say and can update the recipe accordingly

[cjobinabo]

@ranuradh I recently learned you can use https://docs.openrewrite.org/recipes/java/migrate/removemethodinvocation for this change

[ranuradh]

@cjobinabo the recipe only removes the MethodCall where the call's return value is unused. I tried this to remove a constructor. openrewrite/rewrite-static-analysis#273. Hence

import java.lang.Thread;
               
                 public class Test {
               	        public static void main(String args[]) {
               		        Thread t1 = new Thread();
               		        Thread t2 = new Thread();
               		        t1.countStackFrames();
               		        t2.countStackFrames();
               	  }              
              }   

will work but the following wont work:

public class Test {
               	        public static void main(String args[]) {
               		        Thread t1 = new Thread();
               		        Thread t2 = new Thread();
               		        int x = t1.countStackFrames();
               		        int y = t2.countStackFrames();
               	  }        

[ranuradh]

@cjobinabo as discussed I updated the recipe to now use RemoveMethodInvocation

[github-actions]

Some suggestions could not be made:

• src/test/java/org/openrewrite/java/migrate/lombok/LombokValueToRecordTest.java
  • lines 412-412

[github-actions]

Some suggestions could not be made:

• src/test/java/org/openrewrite/java/migrate/lombok/LombokValueToRecordTest.java
  • lines 412-412

[ranuradh]

Hi @timtebeek this recipe is ready for merge

[timtebeek]

Nice and minimal; wondering if we should do anything for the cases where it is assigned to a variable, although I'd think those are rare.

[timtebeek]

Somehow this now fails with

UpgradeToJava17Test > replaceLogRecordSetThreadID() FAILED
    java.lang.AssertionError: [Recipe validation must have no failures] 
    Expecting no elements of:
      [[Valid{property='initialization', value='org.openrewrite.config.DeclarativeRecipe@2197c885'},
        Invalid{property='org.openrewrite.java.migrate.UpgradeToJava17.recipeList[19] (in file:///home/runner/work/rewrite-migrate-java/rewrite-migrate-java/build/resources/main/META-INF/rewrite/java-version-17.yml)', value='org.openrewrite.java.migrate.RemovedFileIOFinalizeMethods', message='recipe 'org.openrewrite.java.migrate.RemovedFileIOFinalizeMethods' does not exist.'},
        Valid{property='initialization', value='org.openrewrite.config.DeclarativeRecipe@2197c885'},
        Invalid{property='org.openrewrite.java.migrate.UpgradeToJava17.recipeList[19] (in file:///home/runner/work/rewrite-migrate-java/rewrite-migrate-java/build/resources/main/META-INF/rewrite/java-version-17.yml)', value='org.openrewrite.java.migrate.RemovedFileIOFinalizeMethods', message='recipe 'org.openrewrite.java.migrate.RemovedFileIOFinalizeMethods' does not exist.'},