Optimize StringFormatted for performance
#201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `StringFormatted` recipe appears to have very bad performance. This one is actually quite easy to implement "manually" without the convenience of `JavaTemplate`, as it basically only shuffles the arguments around.
|
@sambsnyd @timtebeek Maybe you can also check and see if you agree this recipe has bad performance. Also, it remains to be seen if this fix actually helps (possibly it is the |
|
Seems reasonable to me; thanks for taking the time to revise this one. Can't say much as to the performance aspect; I very much agree with you that it's a likely improvement. Suggest we merge this as it is, and look at the daily recipe runs if the data tables show any change in performance there. |
timtebeek
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StringFormattedrecipe appears to have very bad performance. This one is actually quite easy to implement "manually" without the convenience ofJavaTemplate, as it basically only shuffles the arguments around.