NoJodaTime - add unused import when static imports used

[philippe-granet]

What version of OpenRewrite are you using?

I am using

• OpenRewrite latest
• Maven plugin latest
• rewrite-migrate-java latest

How are you running OpenRewrite?

I am using the Maven plugin, and my project is a single module project.

<plugin>
  <groupId>org.openrewrite.maven</groupId>
  <artifactId>rewrite-maven-plugin</artifactId>
  <version>LATEST</version>
  <configuration>
    ... 
  </configuration>
</plugin>

What is the smallest, simplest way to reproduce the problem?

When I have theses imports:

import static java.time.Instant.ofEpochMilli;
import static java.time.ZoneId.systemDefault;

What did you expect to see?

No code modifications after running NoJodaTime recipe

What did you see instead?

import java.time.Instant;
import java.time.ZoneId;
import static java.time.Instant.ofEpochMilli;
import static java.time.ZoneId.systemDefault;

[timtebeek]

Hi @philippe-granet ; thanks for reporting this one! It's an issue in part due to how imports are handled here, and then caused by a bug in AddImport in openrewrite/rewrite. This test indeed already replicates the problem in https://github.com/openrewrite/rewrite/blob/36acd596ac08ac408f427f89885b1e04aaff98b6/rewrite-java-test/src/test/java/org/openrewrite/java/AddImportTest.java

@Issue("https://github.com/openrewrite/rewrite-migrate-java/issues/665")
@Test
void noChangeOnStaticImports() {
    rewriteRun(
      spec -> spec.recipe(toRecipe(() -> new AddImport<>("java.time.Instant", null, true))),
      // language=java
      java(
        """
          import static java.time.Instant.ofEpochMilli;
          """
      )
    );
}

It's triggered here by the rather eager addition of imports; that shouldn't be an issue due to the "maybe" in there, if it wasn't for the bug.

rewrite-migrate-java/src/main/java/org/openrewrite/java/migrate/joda/JodaTimeVisitor.java

Lines 60 to 85 in 713b88e

	@Override
	public @NonNull J visitCompilationUnit(@NonNull J.CompilationUnit cu, @NonNull ExecutionContext ctx) {
	maybeRemoveImport(JODA_DATE_TIME);
	maybeRemoveImport(JODA_DATE_TIME_ZONE);
	maybeRemoveImport(JODA_TIME_FORMAT);
	maybeRemoveImport(JODA_DURATION);
	maybeRemoveImport(JODA_ABSTRACT_INSTANT);
	maybeRemoveImport(JODA_INSTANT);
	maybeRemoveImport(JODA_INTERVAL);
	maybeRemoveImport("java.util.Locale");
	maybeAddImport(JAVA_DATE_TIME);
	maybeAddImport(JAVA_ZONE_OFFSET);
	maybeAddImport(JAVA_ZONE_ID);
	maybeAddImport(JAVA_INSTANT);
	maybeAddImport(JAVA_TIME_FORMATTER);
	maybeAddImport(JAVA_TIME_FORMAT_STYLE);
	maybeAddImport(JAVA_DURATION);
	maybeAddImport(JAVA_LOCAL_DATE);
	maybeAddImport(JAVA_LOCAL_TIME);
	maybeAddImport(JAVA_TEMPORAL_ISO_FIELDS);
	maybeAddImport(JAVA_CHRONO_FIELD);
	maybeAddImport(JAVA_UTIL_DATE);
	maybeAddImport(THREE_TEN_EXTRA_INTERVAL);
	return super.visitCompilationUnit(cu, ctx);
	}