Add validation to ChangeDependency, so it checks that either group or artifact is different from the old.

[timtebeek]

What problem are you trying to solve?

the Change*Dependency… recipes are specifically for changing to a different dependency (as the name implies, doh!). The fact that it has a newVersion parameter tripped me up. I see UpgradeDependencyVersion does what I expected.
A reference from Change… to Upgrade may be helpful. In fact I see Change… being used supposedly to perform an upgrade (judging from the recipe docs) when perhaps an Upgrade… was intended. If the old and the new G+A are identical and newVersion is specified, then it's not a move/change and likely should be an Upgrade.

Describe the solution you'd like

Add validation to ChangeDependency, so it checks that either group or artifact is different from the old. This would apply to both the rewrite-java-dependency recipe, as well as the two rewrite-maven recipes.

Have you considered any alternatives or workarounds?

use a yaml rewrite recipe to change existing recipies (like the ones above) to use Upgrade if the new and old G+A are the same. use a yaml rewrite recipe to change existing recipies (like the ones above) to use Upgrade if the new and old G+A are the same.

Additional context

As suggested on OSS Slack by @tobli

[timtebeek]

Here are some examples I found:

• https://github.com/openrewrite/rewrite-okhttp/blob/f541bf1567863ecbd0f531a80c8e458176889be9/src/main/resources/META-INF/rewrite/okio-3.yml#L37-L41
• https://github.com/openrewrite/rewrite-micrometer/blob/4e4e71a0b2e8dd78477a4fcac71[…]d6048dc3577c/src/main/resources/META-INF/rewrite/micrometer.yml
• https://github.com/openrewrite/rewrite-okhttp/blob/f541bf1567863ecbd0f531a80c8e458176889be9/src/main/resources/META-INF/rewrite/okhttp-4.yml#L33-L36