Fix: Invite and Assignment Pre-Process Quota #2535
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
openreview/venue/process/invite_assignment_pre_process.js:60
- [nitpick] The comment is misleading; since the code returns '!includesFilteredLabel', the comment should note that the edge is included only if it does NOT contain any of the filtered labels.
// Include edge only if it contains any of the filteredLabels and is not the current edge
openreview/venue/process/assignment_pre_process.js:39
- [nitpick] The comment does not accurately reflect the filtering logic; it should state that an edge is included only if it does NOT contain any of the filtered labels and is not the current edge.
// Include edge only if it contains any of the filteredLabels and is not the current edge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks for substring matching instead of strict equality for the current Invite_Assignment and Assignment edge in the quota.
This is to fix a bug where reviewers decline with a reason and the edge.label field contains
Decline: reason. This edge is then incorrectly counted towards the quota to limit the number of active invitations for review + assignment edges.