-
Notifications
You must be signed in to change notification settings - Fork 206
Closed
openresty/meta-lua-nginx-module
#78Description
Hi,
I think https://github.com/openresty/stream-lua-nginx-module/blob/master/src/api/ngx_stream_lua_api.h is not usable currently.
Since ngx_stream_lua_request_t defined in below, are not exported, including ngx_stream_lua_api.h solely makes compile failed.
stream-lua-nginx-module/src/ngx_stream_lua_request.h
Lines 22 to 35 in e3eb228
| typedef struct ngx_stream_lua_request_s ngx_stream_lua_request_t; | |
| typedef void (*ngx_stream_lua_event_handler_pt)(ngx_stream_lua_request_t *r); | |
| struct ngx_stream_lua_request_s { | |
| ngx_connection_t *connection; | |
| ngx_stream_session_t *session; | |
| ngx_pool_t *pool; | |
| ngx_stream_lua_cleanup_t *cleanup; | |
| ngx_stream_lua_event_handler_pt read_event_handler; | |
| ngx_stream_lua_event_handler_pt write_event_handler; | |
| }; |
Currently, I added #include "../ngx_stream_lua_request.h" to ngx_stream_lua_api.h for workaround, but only exporting ngx_stream_lua_request_t will be more suitable.
I want to submit pull request. Is moving ngx_stream_lua_request_t to ngx_stream_lua_api.h and include ngx_stream_lua_api.h from ngx_stream_lua_request.h suitable?
Metadata
Metadata
Assignees
Labels
No labels