Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppcheck issues #16

Closed
chipitsine opened this issue Apr 24, 2016 · 1 comment
Closed

cppcheck issues #16

chipitsine opened this issue Apr 24, 2016 · 1 comment

Comments

@chipitsine
Copy link
Contributor

[src/ngx_stream_lua_regex.c:444] -> [src/ngx_stream_lua_regex.c:465]: (warning) Possible null pointer dereference: lmcf - otherwise it is redundant to check it against null.

[src/ngx_stream_lua_regex.c:903] -> [src/ngx_stream_lua_regex.c:924]: (warning) Possible null pointer dereference: lmcf - otherwise it is redundant to check it against null.

[src/ngx_stream_lua_regex.c:1644] -> [src/ngx_stream_lua_regex.c:1665]: (warning) Possible null pointer dereference: lmcf - otherwise it is redundant to check it against null.
agentzh added a commit that referenced this issue Apr 25, 2016
@agentzh
removed unnecessary pointer checks found by Ilya Shipitsin via cppche…
0c4e019 
…ck in #16.
@agentzh
Copy link
Member

agentzh commented Apr 25, 2016

@chipitsine Fixed. Thanks.

@agentzh agentzh closed this as completed Apr 25, 2016
doujiang24 pushed a commit to doujiang24/stream-lua-nginx-module that referenced this issue Aug 17, 2016
@agentzh
bugfix: downstream socket leaks might happen.
50fe6cb 
This issue was caught by the HUP reload testing mode when running
t/129-ssl-socket.t:

TEST 21: unix domain ssl cosocket (no verify) - pattern "[alert]"
should not match any line in error.log but matches line "2016/02/08
05:39:39 [alert] 416#0: *136 open socket openresty#16 left in connection 9"
agentzh pushed a commit that referenced this issue Oct 26, 2017
@dndx
Updated to NGINX 1.13.5 and latest lua-nginx-module. Fixed broken Tra…
569c91d 
…vis tests. (#16)

* updated to latest meta. #386344f
* travis: updated to use NGINX 1.13.5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agentzh @chipitsine