feature: resty: impelented the --dry-run option to print out the generated configuration. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rated configuration.
agentzh
requested changes
Jun 8, 2018
bin/resty
Outdated
| @@ -289,6 +289,11 @@ my $lua_shared_dicts = ''; | |||
| next; | |||
| } | |||
|
|
|||
| if ($arg =~ /^--dry-run$/) { | |||
There was a problem hiding this comment.
This is not really a "dry run" in the common sense and thus is confusing. I suggest using the option name --dump-nginx-conf instead? Better be explicit for such features.
|
@agentzh |
agentzh
requested changes
Jun 11, 2018
bin/resty
Outdated
| @@ -289,6 +289,11 @@ my $lua_shared_dicts = ''; | |||
| next; | |||
| } | |||
|
|
|||
| if ($arg =~ /^--dump-nginx-conf$/) { | |||
There was a problem hiding this comment.
I think we should just use the eq operator here since it's a constant string comparison.
bin/resty
Outdated
| @@ -777,6 +779,16 @@ $loader | |||
| } | |||
| _EOC_ | |||
|
|
|||
| if ($dump_nginx_conf) { | |||
| print $conf; | |||
| exit(0); | |||
There was a problem hiding this comment.
Better just use exit; here since both the parentheses and 0 can be omitted.
|
@agentzh |
thibaultcha
reviewed
Oct 21, 2018
bin/resty
Outdated
| @@ -894,6 +906,10 @@ Options: | |||
| in the future). | |||
|
|
|||
| -V Print version numbers and nginx configurations. | |||
|
|
|||
| --dump-nginx-conf Print out the generated nginx configuration file only | |||
| without running the Lua code. | |||
There was a problem hiding this comment.
I think we can omit "out" and "only" from this sentence, and maybe be more explicit even:
Print the generated nginx configuration file, without running nginx nor the Lua code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.